Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19644 )
Change subject: IMPALA-12008: Fix incorrect end time in DML profiles ...................................................................... Patch Set 3: Code-Review+1 This code looks good to me. I have 2 improvement suggestion if they make sense: 1). Add "Duration" info string under Summary node. Currently there is no way in profile to look for query duration/latency. User need to do their own math (End Time - Start Time), or my habit is to look at "Released admission control resources" event directly to quickly find the query duration. 2). Add new event "Query complete" on UpdateEndTime(). Now that "Released admission control resources" event does not always mean "the end" of a query, adding a new event specifically marking the query completion would be great. I think this require UpdateEndTime() to be called only once and need to be consistent with "End Time". This might also duplicate with existing "Request finished" event. -- To view, visit http://gerrit.cloudera.org:8080/19644 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c5dc92c2f8576ceed374d447c0ac05022a2dee6 Gerrit-Change-Number: 19644 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Apr 2023 19:26:13 +0000 Gerrit-HasComments: No
