Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19644 )
Change subject: IMPALA-12008: Fix incorrect end time in DML profiles ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19644/4/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/19644/4/be/src/service/client-request-state.cc@157 PS4, Line 157: summary_profile_->AddInfoString("Duration", ""); > Good point! However, I made the change and found the "Duration" was printed Personally I prefer an actual counter than info string, because I do analysis using scripts over thrift profile. There is a difference between TCounter and TEventSequence (timeline). TCounter is more straightforward to search. Info string is best for human though. How about we meet in the middle by having it as info string, but display both the PrettyPrint and miliseconds granularity? like Duration: 1m3s (63123 ms) -- To view, visit http://gerrit.cloudera.org:8080/19644 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c5dc92c2f8576ceed374d447c0ac05022a2dee6 Gerrit-Change-Number: 19644 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Apr 2023 03:30:28 +0000 Gerrit-HasComments: Yes
