Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19634 )
Change subject: IMPALA-12047: [DOCS] Fix a URL mistake when using "git clone" in docs/README.md ...................................................................... Patch Set 2: (3 comments) Thanks, some more remarks. http://gerrit.cloudera.org:8080/#/c/19634/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19634/2//COMMIT_MSG@8 PS2, Line 8: You should describe the problem shortly also here, like in the Jira ticket, and how this change solves the problem. For example: There's a URL mistake when using "git clone" in docs/README.md: git clone https://gitbox.apache.org/repos/asf/impala.git/docs This doesn't work and it will prompt "repository not found". This change corrects the description, providing two ways to download the docs - either by downloading the whole repository and going to the docs/ directory or by downloading only the docs using git sparse-checkout. http://gerrit.cloudera.org:8080/#/c/19634/2/docs/README.md File docs/README.md: http://gerrit.cloudera.org:8080/#/c/19634/2/docs/README.md@13 PS2, Line 13: * Clone the whole repository. Open a terminal window and run the following commands to get the whole Impala We limit line length to 90 in Impala (except for cases where line breaks are not possible, e.g. links). Some of the lines in this change are too long. http://gerrit.cloudera.org:8080/#/c/19634/2/docs/README.md@14 PS2, Line 14: repository from Git: Could add: "[from Git] and go to the docs folder:", because in the instructions we change directory to docs. -- To view, visit http://gerrit.cloudera.org:8080/19634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib00c37e28e67cca5b3630742b4c366dea4e967b7 Gerrit-Change-Number: 19634 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <lith_ang...@foxmail.com> Gerrit-Reviewer: Anonymous Coward <lith_ang...@foxmail.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Thu, 13 Apr 2023 08:29:07 +0000 Gerrit-HasComments: Yes
