Peter Rozsa has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19634 )

Change subject: IMPALA-12047: [DOCS] Fix a URL mistake when using "git clone" 
in docs/README.md
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19634/3/docs/README.md
File docs/README.md:

http://gerrit.cloudera.org:8080/#/c/19634/3/docs/README.md@15
PS3, Line 15:   ```
> I'm not a markdown expert but I tried this with an online markdown renderer
As Daniel pointed out, the fenced code blocks should be aligned as part of the 
list item


http://gerrit.cloudera.org:8080/#/c/19634/3/docs/README.md@33
PS3, Line 33:   You'll see only the 'docs/' sub-directory is downloaded.
nit: The two ways of obtaining create two different states: the first one is in 
the docs/ folder, and the second one is in the impala_docs folder, one level 
upper. The second approach could include the 'cd docs/' command as well.



--
To view, visit http://gerrit.cloudera.org:8080/19634
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib00c37e28e67cca5b3630742b4c366dea4e967b7
Gerrit-Change-Number: 19634
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <lith_ang...@foxmail.com>
Gerrit-Reviewer: Anonymous Coward <lith_ang...@foxmail.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>
Gerrit-Comment-Date: Fri, 14 Apr 2023 14:49:00 +0000
Gerrit-HasComments: Yes

Reply via email to