Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/19744 )
Change subject: IMPALA-11970: Optimized rendering for the query timeline display ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/19744/4/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19744/4/www/query_timeline.tmpl@176 PS4, Line 176: .replace("KrpcDataStreamSender", "SENDER").replace("Hash Join Builder", "JOIN BUILD") > Use 4 space indent for line continuation Done http://gerrit.cloudera.org:8080/#/c/19744/4/www/query_timeline.tmpl@365 PS4, Line 365: timing_ctx.fillText("O", name_width + Math.min.apply(null,node.events[2].tslist) * px_per_ns, > Use 4 space indent for line continuation Done http://gerrit.cloudera.org:8080/#/c/19744/4/www/query_timeline.tmpl@369 PS4, Line 369: > Use 4 space indent for line continuation Done http://gerrit.cloudera.org:8080/#/c/19744/5/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19744/5/www/query_timeline.tmpl@313 PS5, Line 313: var screen_height = Math.min(timing_canvas.height + 10, : window.innerHeight - timing_canvas.offsetTop - 30); Fixed indent -- To view, visit http://gerrit.cloudera.org:8080/19744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec458602266863b6e313f52b26a2dc35cff0db0f Gerrit-Change-Number: 19744 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Tue, 18 Apr 2023 05:40:39 +0000 Gerrit-HasComments: Yes
