Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/19744 )
Change subject: IMPALA-11970: Optimized rendering for the query timeline display ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/19744/5/www/query_timeline.tmpl File www/query_timeline.tmpl: http://gerrit.cloudera.org:8080/#/c/19744/5/www/query_timeline.tmpl@130 PS5, Line 130: maxts > define maxts around line #84 had thought it was already declared, and certainly its not a good practice to declare global variables without the 'var' keyword. http://gerrit.cloudera.org:8080/#/c/19744/5/www/query_timeline.tmpl@151 PS5, Line 151: > it's still indented with 2 spaces. sorry, i have fixed it now. -- To view, visit http://gerrit.cloudera.org:8080/19744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec458602266863b6e313f52b26a2dc35cff0db0f Gerrit-Change-Number: 19744 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Apr 2023 22:41:16 +0000 Gerrit-HasComments: Yes
