Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19796 )
Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py ...................................................................... Patch Set 1: (3 comments) This is super-useful. Thanks for looking into this http://gerrit.cloudera.org:8080/#/c/19796/1/bin/single_node_perf_run.py File bin/single_node_perf_run.py: http://gerrit.cloudera.org:8080/#/c/19796/1/bin/single_node_perf_run.py@181 PS1, Line 181: if (options.split_profiles): Flip this condition? (See other note) http://gerrit.cloudera.org:8080/#/c/19796/1/bin/single_node_perf_run.py@227 PS1, Line 227: for iteration in data[key]: : query_name = iteration["query"]["name"] : start_time = iteration["start_time"] : file_name = "{}_{}.txt".format(start_time, query_name) There are several potential file name formats. We definitely need the query name to group them, and then to identify the specific query run we have options. Start time is unique and would work. Another option would use the iteration count and query id: {query_name}_iter{iter}_{query_id}.txt I think I like putting the query name first. http://gerrit.cloudera.org:8080/#/c/19796/1/bin/single_node_perf_run.py@326 PS1, Line 326: parser.add_option("--split_profiles", action="store_false", : help="If true, query profiles will be generated as separate files") I'm not sure this works. I think split_profiles = True should turn on the new behavior, so the action should be "store_true" and then the condition up in compare() should be flipped? -- To view, visit http://gerrit.cloudera.org:8080/19796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc2d3cefd7ad61b76cbef74c734543ef9ca51795 Gerrit-Change-Number: 19796 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 24 Apr 2023 18:03:59 +0000 Gerrit-HasComments: Yes
