Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19796 )
Change subject: IMPALA-12090: Split runtime profiles made by single_node_perf_run.py ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19796/1/bin/single_node_perf_run.py File bin/single_node_perf_run.py: http://gerrit.cloudera.org:8080/#/c/19796/1/bin/single_node_perf_run.py@181 PS1, Line 181: report_benchmark_results(fil > Flip this condition? (See other note) Done. Thanks for catching this! http://gerrit.cloudera.org:8080/#/c/19796/1/bin/single_node_perf_run.py@227 PS1, Line 227: data = json.loads(fid.read().decode("utf-8", "ignore")) : iter_num = {} : # For each query : for key in data: > There are several potential file name formats. We definitely need the query Done http://gerrit.cloudera.org:8080/#/c/19796/1/bin/single_node_perf_run.py@326 PS1, Line 326: # Less commonly-used options: : parser.add_option("--query_names", > I'm not sure this works. I think split_profiles = True should turn on the n Done -- To view, visit http://gerrit.cloudera.org:8080/19796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc2d3cefd7ad61b76cbef74c734543ef9ca51795 Gerrit-Change-Number: 19796 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 24 Apr 2023 19:10:56 +0000 Gerrit-HasComments: Yes
