Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19850 )
Change subject: WIP IMPALA-11619: Improve Iceberg V2 reads with a custom Iceberg Position Delete operator ...................................................................... Patch Set 4: (17 comments) http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-builder.h File be/src/exec/iceberg-delete-builder.h: http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-builder.h@180 PS4, Line 180: /// immediately succeeds. Returns false and sets 'status' if it was unable to append the row, even after spilling line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.h File be/src/exec/iceberg-delete-node.h: http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.h@64 PS4, Line 64: /// Operator to perform iceberg delete. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.h@95 PS4, Line 95: /// IcebergDeleteState of the builder will drive the iceberg delete algorithm across all the line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.h@121 PS4, Line 121: // This enum drives the state machine in GetNext() that processes probe batches and generates line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.h@126 PS4, Line 126: // producing a variable number of output rows. When the processing is done EOS is entered, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.h@128 PS4, Line 128: // start line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.h@136 PS4, Line 136: // + PROBING_END_BATCH +------------->+ EOS | line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.h@163 PS4, Line 163: bool inline ProcessProbeRow(RowBatch::Iterator* out_batch_iterator, int* remaining_capacity, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.cc File be/src/exec/iceberg-delete-node.cc: http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.cc@67 PS4, Line 67: auto hdfs_table_ = static_cast<const HdfsTableDescriptor*>(tuple_desc_->table_desc()); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.cc@67 PS4, Line 67: auto hdfs_table_ = static_cast<const HdfsTableDescriptor*>(tuple_desc_->table_desc()); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.cc@79 PS4, Line 79: //const string& native_file_path = file_path.native(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.cc@447 PS4, Line 447: auto it = builder_->delete_hash.find(std::string(reinterpret_cast<const char*>(strval.ptr), strval.len)); line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/19850/4/be/src/exec/iceberg-delete-node.cc@470 PS4, Line 470: current_delete_id_it_ = std::lower_bound(it->second.begin(),it->second.end(),current_probe_id_.val); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/19850/4/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/19850/4/common/thrift/Query.thrift@635 PS4, Line 635: 159: optional bool optimized_v2_partitioned = true; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/19850/4/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/19850/4/tests/query_test/test_iceberg.py@1115 PS4, Line 1115: 1 flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/19850/4/tests/query_test/test_iceberg.py@1115 PS4, Line 1115: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/19850/4/tests/query_test/test_iceberg.py@1115 PS4, Line 1115: cls.ImpalaTestMatrix.add_dimension(ImpalaTestDimension('optimized_v2_partitioned', 0, 1)) line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/19850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I024a61573c83bda5584f243c879d9ff39dd2dcfa Gerrit-Change-Number: 19850 Gerrit-PatchSet: 4 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 10 May 2023 14:15:46 +0000 Gerrit-HasComments: Yes
