Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19850 )

Change subject: WIP IMPALA-11619: Improve Iceberg V2 reads with a custom 
Iceberg Position Delete operator
......................................................................


Patch Set 7:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/19850/7/common/thrift/Query.thrift
File common/thrift/Query.thrift:

http://gerrit.cloudera.org:8080/#/c/19850/7/common/thrift/Query.thrift@634
PS7, Line 634:   159: optional TJoinDistributionMode 
optimized_iceberg_v2_read_distribution_mode_override;
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19850/7/common/thrift/Query.thrift@634
PS7, Line 634:   159: optional TJoinDistributionMode 
optimized_iceberg_v2_read_distribution_mode_override;
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/19850/7/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/19850/7/tests/query_test/test_iceberg.py@1115
PS7, Line 1115: 1
flake8: E501 line too long (93 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/19850/7/tests/query_test/test_iceberg.py@1115
PS7, Line 1115:
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/19850/7/tests/query_test/test_iceberg.py@1115
PS7, Line 1115:     
cls.ImpalaTestMatrix.add_dimension(ImpalaTestDimension('optimized_v2_partitioned',
 0, 1))
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/19850
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I024a61573c83bda5584f243c879d9ff39dd2dcfa
Gerrit-Change-Number: 19850
Gerrit-PatchSet: 7
Gerrit-Owner: Gergely Fürnstáhl <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 11 May 2023 13:28:43 +0000
Gerrit-HasComments: Yes

Reply via email to