Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19845 )

Change subject: IMPALA-11260: Add add-opens to JAVA_TOOL_OPTIONS on startup
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19845/3/be/src/common/init.cc
File be/src/common/init.cc:

http://gerrit.cloudera.org:8080/#/c/19845/3/be/src/common/init.cc@310
PS3, Line 310:     "--add-opens=java.base/java.io=ALL-UNNAMED",
> We aren't worried about passing JAVA_TOOL_OPTIONS through to the shell comm
Now that I have a reasonable test, this doesn't seem to work.



--
To view, visit http://gerrit.cloudera.org:8080/19845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47a6533b2aa94593d9348e8e3606633f06a111e8
Gerrit-Change-Number: 19845
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Comment-Date: Thu, 11 May 2023 22:38:38 +0000
Gerrit-HasComments: Yes

Reply via email to