Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19845 )
Change subject: PROTOTYPE IMPALA-11260: Add add-opens to JAVA_TOOL_OPTIONS on startup ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19845/3/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/19845/3/be/src/common/init.cc@310 PS3, Line 310: "--add-opens=java.base/java.io=ALL-UNNAMED", > We could validate that the add-opens are present using code similar to what Logs show that the arguments are available there: I0511 16:12:58.874334 1160016 JniFrontend.java:141] Java Input arguments: -agentlib:jdwp=transport=dt_socket,address=30001,server=y,suspend=n --add-opens=java.base/java.io=ALL-UNNAMED--add-opens=java.base/java.lang.module=ALL-UNNAMED--add-opens=java.base/java.lang.ref=ALL-UNNAMED--add-opens=java.base/java.lang.reflect=ALL-UNNAMED--add-opens=java.base/java.lang=ALL-UNNAMED--add-opens=java.base/java.net=ALL-UNNAMED--add-opens=java.base/java.nio.charset=ALL-UNNAMED--add-opens=java.base/java.nio.file.attribute=ALL-UNNAMED--add-opens=java.base/java.nio=ALL-UNNAMED--add-opens=java.base/java.security=ALL-UNNAMED--add-opens=java.base/java.util.concurrent=ALL-UNNAMED--add-opens=java.base/java.util.jar=ALL-UNNAMED--add-opens=java.base/java.util.zip=ALL-UNNAMED--add-opens=java.base/java.util=ALL-UNNAMED--add-opens=java.base/jdk.internal.loader=ALL-UNNAMED--add-opens=java.base/jdk.internal.math=ALL-UNNAMED--add-opens=java.base/jdk.internal.module=ALL-UNNAMED--add-opens=java.base/jdk.internal.perf=ALL-UNNAMED--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED--add-opens=java.base/jdk.internal.reflect=ALL-UNNAMED--add-opens=java.base/jdk.internal.util.jar=ALL-UNNAMED--add-opens=java.base/sun.nio.fs=ALL-UNNAMED--add-opens=jdk.dynalink/jdk.dynalink.beans=ALL-UNNAMED--add-opens=jdk.dynalink/jdk.dynalink.linker.support=ALL-UNNAMED--add-opens=jdk.dynalink/jdk.dynalink.linker=ALL-UNNAMED--add-opens=jdk.dynalink/jdk.dynalink.support=ALL-UNNAMED--add-opens=jdk.dynalink/jdk.dynalink=ALL-UNNAMED--add-opens=jdk.management.jfr/jdk.management.jfr=ALL-UNNAMED--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED--add-opens=java.base/java.io=ALL-UNNAMED--add-opens=java.base/java.lang.module=ALL-UNNAMED--add-opens=java.base/java.lang.ref=ALL-UNNAMED--add-opens=java.base/java.lang.reflect=ALL-UNNAMED--add-opens=java.base/java.lang=ALL-UNNAMED--add-opens=java.base/java.net=ALL-UNNAMED--add-opens=java.base/java.nio.charset=ALL-UNNAMED--add-opens=java.base/java.nio.file.attribute=ALL-UNNAMED--add-opens=java.base/java.nio=ALL-UNNAMED--add-opens=java.base/java.security=ALL-UNNAMED--add-opens=java.base/java.util.concurrent=ALL-UNNAMED--add-opens=java.base/java.util.jar=ALL-UNNAMED--add-opens=java.base/java.util.zip=ALL-UNNAMED--add-opens=java.base/java.util=ALL-UNNAMED--add-opens=java.base/jdk.internal.loader=ALL-UNNAMED--add-opens=java.base/jdk.internal.math=ALL-UNNAMED--add-opens=java.base/jdk.internal.module=ALL-UNNAMED--add-opens=java.base/jdk.internal.perf=ALL-UNNAMED--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED--add-opens=java.base/jdk.internal.reflect=ALL-UNNAMED--add-opens=java.base/jdk.internal.util.jar=ALL-UNNAMED--add-opens=java.base/sun.nio.fs=ALL-UNNAMED--add-opens=jdk.dynalink/jdk.dynalink.beans=ALL-UNNAMED--add-opens=jdk.dynalink/jdk.dynalink.linker.support=ALL-UNNAMED--add-opens=jdk.dynalink/jdk.dynalink.linker=ALL-UNNAMED--add-opens=jdk.dynalink/jdk.dynalink.support=ALL-UNNAMED--add-opens=jdk.dynalink/jdk.dynalink=ALL-UNNAMED--add-opens=jdk.management.jfr/jdk.management.jfr=ALL-UNNAMED--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED -Djava.library.path=/home/michael/Impala/toolchain/cdp_components-39127492/hadoop-3.1.1.7.2.17.0-160//lib/native/ -XX:ErrorFile=/home/michael/Impala/logs/hs_err_pid%p.log -XX:MaxPermSize=128m -Djava.library.path=/home/michael/Impala/toolchain/cdp_components-39127492/hadoop-3.1.1.7.2.17.0-160//lib/native/ -XX:ErrorFile=/home/michael/Impala/logs/hs_err_pid%p.log -XX:MaxPermSize=128m Java System properties: awt.toolkit:sun.awt.X11.XToolkit java.specification.version:11 sun.management.compiler:HotSpot 64-Bit Tiered Compilers sun.cpu.isalist: sun.jnu.encoding:UTF-8 java.runtime.version:11.0.18+10-post-Ubuntu-0ubuntu120.04.1 ... W0511 16:13:17.853808 1160016 ObjectGraphWalker.java:251] The JVM is preventing Ehcache from accessing the subgraph beneath 'private final java.lang.Runnable jdk.internal.ref.CleanerImpl$PhantomCleanableRef.action' - cache sizes may be underestimated as a result Java exception follows: java.lang.reflect.InaccessibleObjectException: Unable to make field private final java.lang.Runnable jdk.internal.ref.CleanerImpl$PhantomCleanableRef.action accessible: module java.base does not "opens jdk.internal.ref" to unnamed module @47428937 at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:340) at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:280) at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:176) at java.base/java.lang.reflect.Field.setAccessible(Field.java:170) at org.ehcache.sizeof.ObjectGraphWalker.getAllFields(ObjectGraphWalker.java:245) at org.ehcache.sizeof.ObjectGraphWalker.getFilteredFields(ObjectGraphWalker.java:204) at org.ehcache.sizeof.ObjectGraphWalker.walk(ObjectGraphWalker.java:159) at org.ehcache.sizeof.SizeOf.deepSizeOf(SizeOf.java:74) at org.apache.impala.catalog.local.CatalogdMetaProvider$SizeOfWeigher.weigh(CatalogdMetaProvider.java:2018) at com.google.common.cache.LocalCache$Segment.setValue(LocalCache.java:2014) at com.google.common.cache.LocalCache$Segment.storeLoadedValue(LocalCache.java:3162) at com.google.common.cache.LocalCache$Segment.getAndRecordStats(LocalCache.java:2322) at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2283) at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2159) at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2049) at com.google.common.cache.LocalCache.get(LocalCache.java:3966) at com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4863) at org.apache.impala.catalog.local.CatalogdMetaProvider.loadWithCaching(CatalogdMetaProvider.java:522) at org.apache.impala.catalog.local.CatalogdMetaProvider.loadTableList(CatalogdMetaProvider.java:671) at org.apache.impala.catalog.local.LocalDb.loadTableNames(LocalDb.java:173) at org.apache.impala.catalog.local.LocalDb.getAllTableNames(LocalDb.java:158) at org.apache.impala.service.Frontend.getCatalogMetrics(Frontend.java:1038) at org.apache.impala.service.JniFrontend.getCatalogMetrics(JniFrontend.java:234) -- To view, visit http://gerrit.cloudera.org:8080/19845 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47a6533b2aa94593d9348e8e3606633f06a111e8 Gerrit-Change-Number: 19845 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 12 May 2023 17:40:03 +0000 Gerrit-HasComments: Yes
