Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19875 )
Change subject: IMPALA-12134: Optimize row materialization time ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19875/4/be/src/runtime/date-value.cc File be/src/runtime/date-value.cc: http://gerrit.cloudera.org:8080/#/c/19875/4/be/src/runtime/date-value.cc@434 PS4, Line 434: DateParser::FormatDefault(*this, s.data()); > If I understand correctly an invalid date will return a non-empty string st Done -- To view, visit http://gerrit.cloudera.org:8080/19875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ef5e4137fa6c2d0a5f08b430e01e3fb7de86330 Gerrit-Change-Number: 19875 Gerrit-PatchSet: 4 Gerrit-Owner: Kurt Deschler <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Comment-Date: Wed, 17 May 2023 13:45:46 +0000 Gerrit-HasComments: Yes
