Impala Public Jenkins has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/19875 )
Change subject: IMPALA-12134: Optimize row materialization time
......................................................................
IMPALA-12134: Optimize row materialization time
This patch improves row materialization time by providing specialized
formatting logic for default date and timestamp formats. For Beeswax
protocol, performance is also improved by caching deserialized column
metadata to avoid unnecessary per-row cost.
Benchmarks:
- Manually tested mixed datatype table showed ~20% reduction in row
materialization time
- Added cases to date-benchmark for new formatters. Date formatting
improved by 3x and timestamp by 2x
Machine Info: Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz
ToYearMonthDay: Function iters/ms
-------------------------------------------------------
TestCctzToYearMonthDay 16.5
TestToYearMonthDay 61.1
TestToYear 280
TestToString 18
TestToString_stringstream 1.86
TestDefaultDateToCharBuf 25.5
TestTimestampToString 11.7
TestDefaultTimestampToCharBuf 15.7
Testing:
- Ran core tests
Change-Id: I1ef5e4137fa6c2d0a5f08b430e01e3fb7de86330
Reviewed-on: http://gerrit.cloudera.org:8080/19875
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M be/src/benchmarks/date-benchmark.cc
M be/src/runtime/date-parse-util.cc
M be/src/runtime/date-parse-util.h
M be/src/runtime/date-value.cc
M be/src/runtime/datetime-simple-date-format-parser.h
M be/src/runtime/timestamp-parse-util.cc
M be/src/runtime/timestamp-parse-util.h
M be/src/runtime/timestamp-value.cc
M be/src/service/query-result-set.cc
9 files changed, 210 insertions(+), 21 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19875
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ef5e4137fa6c2d0a5f08b430e01e3fb7de86330
Gerrit-Change-Number: 19875
Gerrit-PatchSet: 7
Gerrit-Owner: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>