Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20078 )
Change subject: IMPALA-11877: (part 2) Add support for DELETE statements for PARTITIONED Iceberg tables ...................................................................... Patch Set 1: (4 comments) Hi Zoltan, great feature! Could you add some simple tests on the two new virtual columns as well? http://gerrit.cloudera.org:8080/#/c/20078/1/be/src/exec/file-metadata-utils.h File be/src/exec/file-metadata-utils.h: http://gerrit.cloudera.org:8080/#/c/20078/1/be/src/exec/file-metadata-utils.h@74 PS1, Line 74: nit: comment or empty line http://gerrit.cloudera.org:8080/#/c/20078/1/common/thrift/DataSinks.thrift File common/thrift/DataSinks.thrift: http://gerrit.cloudera.org:8080/#/c/20078/1/common/thrift/DataSinks.thrift@107 PS1, Line 107: 1: required list<Exprs.TExpr> partition_key_exprs nit: comment http://gerrit.cloudera.org:8080/#/c/20078/1/fe/src/main/java/org/apache/impala/analysis/DmlStatementBase.java File fe/src/main/java/org/apache/impala/analysis/DmlStatementBase.java: http://gerrit.cloudera.org:8080/#/c/20078/1/fe/src/main/java/org/apache/impala/analysis/DmlStatementBase.java@93 PS1, Line 93: nit: indentation http://gerrit.cloudera.org:8080/#/c/20078/1/fe/src/main/java/org/apache/impala/catalog/VirtualColumn.java File fe/src/main/java/org/apache/impala/catalog/VirtualColumn.java: http://gerrit.cloudera.org:8080/#/c/20078/1/fe/src/main/java/org/apache/impala/catalog/VirtualColumn.java@40 PS1, Line 40: nit: new line -- To view, visit http://gerrit.cloudera.org:8080/20078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28b06f240c23c336a7c5b6ef22fe2ee0a21f7b60 Gerrit-Change-Number: 20078 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Tue, 20 Jun 2023 10:12:27 +0000 Gerrit-HasComments: Yes
