Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20078 )
Change subject: IMPALA-11877: (part 2) Add support for DELETE statements for PARTITIONED Iceberg tables ...................................................................... Patch Set 1: (7 comments) Found some more nits, I will do another round tomorrow morning with fresh eyes. http://gerrit.cloudera.org:8080/#/c/20078/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20078/1//COMMIT_MSG@60 PS1, Line 60: in way nit: "in a way" http://gerrit.cloudera.org:8080/#/c/20078/1/be/src/exec/file-metadata-utils.cc File be/src/exec/file-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/20078/1/be/src/exec/file-metadata-utils.cc@147 PS1, Line 147: AddVirtualIcebergColumn > I think this is not an 'Add' method but rather a 'Fill' method. FillVirtual For me 'Add' sounds better because it is similar to AddIcebergColumns. 'Set' or 'Add' is more standard. http://gerrit.cloudera.org:8080/#/c/20078/1/be/src/exec/file-metadata-utils.cc@185 PS1, Line 185: nit: empty line http://gerrit.cloudera.org:8080/#/c/20078/1/be/src/exec/hdfs-table-sink.h File be/src/exec/hdfs-table-sink.h: http://gerrit.cloudera.org:8080/#/c/20078/1/be/src/exec/hdfs-table-sink.h@130 PS1, Line 130: name nit: outdated comment http://gerrit.cloudera.org:8080/#/c/20078/1/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionSpec.java File fe/src/main/java/org/apache/impala/analysis/IcebergPartitionSpec.java: http://gerrit.cloudera.org:8080/#/c/20078/1/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionSpec.java@61 PS1, Line 61: specId nit: based on earlier getters, this should be getSpecId() http://gerrit.cloudera.org:8080/#/c/20078/1/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java File fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java: http://gerrit.cloudera.org:8080/#/c/20078/1/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@62 PS1, Line 62: Currently, only Kudu tables can be modified. nit: outdated comment http://gerrit.cloudera.org:8080/#/c/20078/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/20078/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@180 PS1, Line 180: WithSpecId nit: I think the parameter describes this part -- To view, visit http://gerrit.cloudera.org:8080/20078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28b06f240c23c336a7c5b6ef22fe2ee0a21f7b60 Gerrit-Change-Number: 20078 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Thu, 22 Jun 2023 14:08:13 +0000 Gerrit-HasComments: Yes
