Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20224 )
Change subject: IMPALA-12292: TestCodegenCache.{test_codegen_cache_with_asm_module_dir,test_codegen_cache_with_perf_map} fail in builds ...................................................................... Patch Set 1: If I compile it in ASAN mode, it's the other way round, it crashes without IMPALA-12260 if the first query is select int_col from functional_parquet.alltypessmall order by int_col desc limit 20; As dereferencing a NULL pointer is undefined behaviour, it's actually ok, but we'll have to find a way to test it well, we can't rely on the crash. I'll check if we can use debug actions. -- To view, visit http://gerrit.cloudera.org:8080/20224 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15320b8c0d06f4d93927b19731c11bd4e15b3690 Gerrit-Change-Number: 20224 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Fri, 21 Jul 2023 16:16:08 +0000 Gerrit-HasComments: No