Daniel Becker has posted comments on this change. (
http://gerrit.cloudera.org:8080/20224 )
Change subject: IMPALA-12292:
TestCodegenCache.{test_codegen_cache_with_asm_module_dir,test_codegen_cache_with_perf_map}
fail in builds
......................................................................
Patch Set 2:
Yida Wu yes, that is related. Now I ran it after a rebase and got a different
kind of error. It seems this test is very sensitive to changes. Maybe we should
set the cache size adaptively. Or do you have any other idea how to ensure that
the two cached execution engines from the first query fit in the cache but are
both ejected during the second query?
If we decide to do it adaptively, I think it can be done but it will take some
time, maybe we should temporarily disable these tests in the meantime. What do
you think?
--
To view, visit http://gerrit.cloudera.org:8080/20224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15320b8c0d06f4d93927b19731c11bd4e15b3690
Gerrit-Change-Number: 20224
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
Gerrit-Comment-Date: Wed, 26 Jul 2023 11:55:35 +0000
Gerrit-HasComments: No
