Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20022 )
Change subject: IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/20022/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20022/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1491 PS6, Line 1491: */ : @Override : public void process() throws MetastoreNotificationException, CatalogException { : if (isRename_) { : processRename(); : return; : } : : if (isOlderEvent(null)) { : > I am trying to understand the RENAME case. I think that it would be clearer Ack http://gerrit.cloudera.org:8080/#/c/20022/6/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2341 PS6, Line 2341: rivialAlterP > I am trying to understand what will happen in the batched case. No, I'm iterating over each of the partitions and then checking if the partition's eventId is greater than the current eventId. Sure, I can add the above-mentioned test. http://gerrit.cloudera.org:8080/#/c/20022/6/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20022/6/tests/custom_cluster/test_events_custom_configs.py@315 PS6, Line 315: catalogd_args > Is there a reason why enable_sync_to_latest_event_on_ddls is true in the Ja Some of the events depend on enable_sync_to_latest_event_on_ddls to be enabled. In this particular test, we don't actually need it. Once, the performance and stability of catalogD features are completed, we plan to turn on these configs by default. -- To view, visit http://gerrit.cloudera.org:8080/20022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0dc5c7396d80616680d8a5805ce80db293b72e1 Gerrit-Change-Number: 20022 Gerrit-PatchSet: 7 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Aug 2023 19:19:20 +0000 Gerrit-HasComments: Yes
