Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20022 )
Change subject: IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID ...................................................................... Patch Set 10: (2 comments) With the flag default as false the change seems safe to me. Thanks for the work! Few more comments about the tests. http://gerrit.cloudera.org:8080/#/c/20022/7/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20022/7/tests/custom_cluster/test_events_custom_configs.py@348 PS7, Line 348: insert into Can you also add a test with dynamic partitioning? http://gerrit.cloudera.org:8080/#/c/20022/7/tests/custom_cluster/test_events_custom_configs.py@357 PS7, Line 357: tbl_events_skipped_before Can't we use fixed numbers in the test, e.g. assert tbl_events_skipped_after == tbl_events_skipped_before + 3? I don't know how many events we will skip exactly, but it seems possible that other skippable events are also triggered besides the inserts. -- To view, visit http://gerrit.cloudera.org:8080/20022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0dc5c7396d80616680d8a5805ce80db293b72e1 Gerrit-Change-Number: 20022 Gerrit-PatchSet: 10 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 17 Aug 2023 10:21:56 +0000 Gerrit-HasComments: Yes
