Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20376 )
Change subject: IMPALA-12384: Restore NullLiteral's uncheckedCastTo function signature ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20376/1/fe/src/main/java/org/apache/impala/analysis/NullLiteral.java File fe/src/main/java/org/apache/impala/analysis/NullLiteral.java: http://gerrit.cloudera.org:8080/#/c/20376/1/fe/src/main/java/org/apache/impala/analysis/NullLiteral.java@68 PS1, Line 68: protected Expr uncheckedCastTo(Type targetType) { Do we also need to implement uncheckedCastTo with the compatibility argument? If that function's called elsewhere it seems like it could return the wrong result. I was thinking the change would be to override both. -- To view, visit http://gerrit.cloudera.org:8080/20376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c01129d3cdcaeb222ea910521704ce2305fd2e Gerrit-Change-Number: 20376 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Fri, 18 Aug 2023 17:19:39 +0000 Gerrit-HasComments: Yes
