Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/20376 )
Change subject: IMPALA-12384: Restore NullLiteral's uncheckedCastTo function signature ...................................................................... Patch Set 2: (1 comment) > Patch Set 1: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/20376/1/fe/src/main/java/org/apache/impala/analysis/NullLiteral.java File fe/src/main/java/org/apache/impala/analysis/NullLiteral.java: http://gerrit.cloudera.org:8080/#/c/20376/1/fe/src/main/java/org/apache/impala/analysis/NullLiteral.java@68 PS1, Line 68: > Do we also need to implement uncheckedCastTo with the compatibility argumen Thank you for noticing it, it's indeed causing a problem, I added the missing/changed overload. -- To view, visit http://gerrit.cloudera.org:8080/20376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9c01129d3cdcaeb222ea910521704ce2305fd2e Gerrit-Change-Number: 20376 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Aug 2023 13:30:40 +0000 Gerrit-HasComments: Yes
