Peter Rozsa has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20385 )
Change subject: IMPALA-12386: Fix clone constructor in CastExpr ...................................................................... IMPALA-12386: Fix clone constructor in CastExpr This commit addresses an issue in the CastExpr class where the clone constructor was not properly preserving compatibility settings. The clone constructor assigned the default compatibility regardless of the source expression, causing substitution errors later. Example: 'insert into t01(a, b) values(null, "23"), ("21", null)' Throws: ERROR: IllegalStateException: Failed analysis after expr substitution. CAUSED BY: IllegalStateException: cast STRING to INT Tests: - new test case added to insert-unsafe.test Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f --- M fe/src/main/java/org/apache/impala/analysis/CastExpr.java M testdata/workloads/functional-query/queries/QueryTest/insert-unsafe.test 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/20385/2 -- To view, visit http://gerrit.cloudera.org:8080/20385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f Gerrit-Change-Number: 20385 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com>