Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20385 )
Change subject: IMPALA-12386: Fix clone constructor in CastExpr ...................................................................... Patch Set 2: (1 comment) Thanks, just a small suggestion. http://gerrit.cloudera.org:8080/#/c/20385/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20385/2//COMMIT_MSG@15 PS2, Line 15: 'insert into t01(a, b) values(null, "23"), ("21", null)' Thinking about it, using the example from the test would be better as the column names are more informative. -- To view, visit http://gerrit.cloudera.org:8080/20385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff64ce02539651fcb3a90db678f74467f582648f Gerrit-Change-Number: 20385 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Aug 2023 14:10:18 +0000 Gerrit-HasComments: Yes
