Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 )
Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/20379/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java File fe/src/main/java/org/apache/impala/planner/AggregationNode.java: http://gerrit.cloudera.org:8080/#/c/20379/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@83 PS4, Line 83: finalize > nit node? Done http://gerrit.cloudera.org:8080/#/c/20379/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@172 PS4, Line 172: Preconditions.checkState(needsFinalize_ && !endsMultiPhase_); > && !endsMultiPhase_ Done http://gerrit.cloudera.org:8080/#/c/20379/4/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@786 PS4, Line 786: && isMultiPhase() > I wonder if this effectively requires all non-root aggregation nodes (i.e., isMultiPhase encompasses all nodes that are part of a chain of aggregation nodes. Most of them useIntermediateTuple_. So this change should not introduce any behavioral changes in DistributedPlanner, and only affects SingleNodePlanner for simple cases (no aggregate expressions or conjuncts). Is there a particular case it would be useful to test? It might be possible to fix this by counting. It would require adding additional logic to double-check and possibly truncate results coming from aggregating individual partitions. Fixing one case that was missed in the planning stage seemed more straight-forward. -- To view, visit http://gerrit.cloudera.org:8080/20379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816 Gerrit-Change-Number: 20379 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 22 Aug 2023 18:42:20 +0000 Gerrit-HasComments: Yes
