Hello Quanlong Huang, Qifan Chen, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20379
to look at the new patch set (#7).
Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits
......................................................................
IMPALA-12383: Fix SingleNodePlanner aggregation limits
When IMPALA-2581 was implemented, it assumed all aggregation nodes would
have a pre-aggregation step that limits could be pushed to. That's not
the case when using SingleNodePlanner, such as when num_nodes=1. As a
result, the following query would incorrectly return 16 rows, not 10:
set num_nodes=1;
select distinct l_orderkey from tpch.lineitem limit 10;
This fix identifies all aggregation nodes that use pre-aggregation so we
use fast_limit_check in only those cases.
Testing:
- added a test case where we assert number of rows returned by an
aggregation node (rather than an exchange or top-n).
- restores definition of ALL_CLUSTER_SIZES and makes it simpler to
enable for individual test suites. Filed IMPALA-12394 to generally
re-enable testing with ALL_CLUSTER_SIZES. Enables ALL_CLUSTER_SIZES
for aggregation tests.
- passed an exhaustive test run.
Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816
---
M fe/src/main/java/org/apache/impala/planner/AggregationNode.java
M fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M tests/common/impala_test_suite.py
M tests/common/test_dimensions.py
M tests/query_test/test_aggregation.py
6 files changed, 47 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/20379/7
--
To view, visit http://gerrit.cloudera.org:8080/20379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816
Gerrit-Change-Number: 20379
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
