Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 )
Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/20366/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20366/6//COMMIT_MSG@23 PS6, Line 23: : 3. The planned bloom filter has fpp estimate higher than 0.9 can you mention the query option? http://gerrit.cloudera.org:8080/#/c/20366/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20366/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@858 PS2, Line 858: ter.src_.getChild(1 > Yes. Basically the reason we have hasEliminatedFilter flag and loop one mor Thanks for the explanation! Can you add a comment about the role of the inner and outer loop? http://gerrit.cloudera.org:8080/#/c/20366/6/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20366/6/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@843 PS6, Line 843: if (BackendConfig.INSTANCE.getMaxFilterErrorRateFromFullScan() >= 0) { nit: would prefer returning early for < 0 case to reduce nesting http://gerrit.cloudera.org:8080/#/c/20366/6/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@859 PS6, Line 859: while (buildSourceNode.getChild(0) != null) { What would happen with nodes where there is also a right child, for example in a UNION ALL? Shouldn't we ensure that all children are without predicates in that case? -- To view, visit http://gerrit.cloudera.org:8080/20366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I494533bc06da84e606cbd1ae1619083333089a5e Gerrit-Change-Number: 20366 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 29 Aug 2023 16:42:13 +0000 Gerrit-HasComments: Yes
