David Rorke has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 )
Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20366/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20366/7//COMMIT_MSG@27 PS7, Line 27: K-FK relationship is rarely defined and enforced at table schema : definition. Therefore, the third criteria replace the PK-FK relationship : characteristic checks I think we could also try to detect likely PK-FK joins here as an additional criteria, using heuristics similar to what we use in JoinNode.getJoinCardinality. If we think we can detect the PK-FK case with some level of reliability, it isn't obvious to me that we need the FPP check. Or if we do want a max FPP check, maybe that should be a completely independent check from this and also have a configurable threshold. -- To view, visit http://gerrit.cloudera.org:8080/20366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I494533bc06da84e606cbd1ae1619083333089a5e Gerrit-Change-Number: 20366 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 30 Aug 2023 16:07:45 +0000 Gerrit-HasComments: Yes
