Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20445 )
Change subject: IMPALA-12390 (part 2): Enable some clang-tidy performance related checks ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20445/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20445/4//COMMIT_MSG@10 PS4, Line 10: performance-inefficient-string-concatenation This looks like it requires a change to .clang-tidy. Presumably it should wait until after https://gerrit.cloudera.org/c/20387/ is merged. -- To view, visit http://gerrit.cloudera.org:8080/20445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibad8bd0f12aab92ad874f5a6b9ec922dce7f3190 Gerrit-Change-Number: 20445 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Wed, 06 Sep 2023 16:24:26 +0000 Gerrit-HasComments: Yes
