Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20445 )
Change subject: IMPALA-12390 (part 2): Enable some clang-tidy performance related checks ...................................................................... Patch Set 4: Now that https://gerrit.cloudera.org/#/c/20387/ has merged, please rebase on top of it. Then also do the .clang-tidy change that Michael mentioned to enable this by default. There is one usability thing that I would like to add to this change. Since we are mostly solving this using StrCat(), it would be nice for our clang-tidy output to mention it if performance-inefficient-string-concatenation is mentioned. I would preserve the original Clang message and append an Impala specific note saying that Impala code can also solve the issue using the StrCat() function from be/src/gutil/strings/strcat.h. One way to do that is to pipe output through this: sed '/performance-inefficient-string-concatenation/ s#$# (Impala-specific note: This can also be fixed using the StrCat() function from be/src/gutil/strings/strcat.h)#' It matches the performance-inefficient-string-concatenation lines and replaces the end of line with our message. We'll have to figure out the right part of bin/run_clang_tidy.sh to modify. -- To view, visit http://gerrit.cloudera.org:8080/20445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibad8bd0f12aab92ad874f5a6b9ec922dce7f3190 Gerrit-Change-Number: 20445 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Sep 2023 16:58:02 +0000 Gerrit-HasComments: No
