Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 )
Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/20379/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20379/9//COMMIT_MSG@21 PS9, Line 21: This fix restores limits on the aggregation node; > nit. This fix properly configures the aggregate node to avoid early complet Is that update true? Early completion comes on the streaming sender side of aggregation, which still happens (if a streaming sender exists). In a distributed plan, the exchange also enforced the limit. This patch restores the limit on the aggregation node, which is also used to end once the limit is reached. I don't see how that "avoids early completion". http://gerrit.cloudera.org:8080/#/c/20379/9/be/src/exec/grouping-aggregator.h File be/src/exec/grouping-aggregator.h: http://gerrit.cloudera.org:8080/#/c/20379/9/be/src/exec/grouping-aggregator.h@a196 PS9, Line 196: > nit. noEarlyCompletion better describes the semantics. It's been removed, so this no longer exists. http://gerrit.cloudera.org:8080/#/c/20379/9/be/src/exec/grouping-aggregator.h@a218 PS9, Line 218: > nit. Can we use setNoEarlyCompletion() instead? This function was removed. It was originally added in https://gerrit.cloudera.org/c/17821/18/be/src/exec/grouping-aggregator.h#218. -- To view, visit http://gerrit.cloudera.org:8080/20379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816 Gerrit-Change-Number: 20379 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 07 Sep 2023 16:22:22 +0000 Gerrit-HasComments: Yes
