Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 )
Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/20379/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20379/9//COMMIT_MSG@9 PS9, Line 9: IMPALA-2581 added enforcement of the limit when adding entries to the : grouping aggregation. It would stop adding new entries if the number of : entries in the grouping aggregation was >= the limit. If the grouping : aggregation never contains more entries than the limit, then it would : not output more > Here's what I think the thought process was: Ack http://gerrit.cloudera.org:8080/#/c/20379/9//COMMIT_MSG@22 PS9, Line 22: select distinct l_orderkey from tpch.lineitem limit 10; > Nit: For a distributed plan, it won't impact the query result, but it does I rewrote the commit message. Do you think mentioning this is still needed? -- To view, visit http://gerrit.cloudera.org:8080/20379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5eec1190e8e182152aa954897b79cc3f219c816 Gerrit-Change-Number: 20379 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qfc...@hotmail.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 07 Sep 2023 17:19:30 +0000 Gerrit-HasComments: Yes
