Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 )
Change subject: IMPALA-12313: (part 1) Refactor modify statements ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/20477/1/fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java File fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java: http://gerrit.cloudera.org:8080/#/c/20477/1/fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java@84 PS1, Line 84: Set<SlotId> uniqueSlots, Set<SlotId> keySlots, Map<String, Integer> colIndexMap) line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/20477/1/fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java File fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java: http://gerrit.cloudera.org:8080/#/c/20477/1/fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java@55 PS1, Line 55: List<Integer> referencedColumns, Set<SlotId> uniqueSlots, Set<SlotId> keySlots, line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/20477/1/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java File fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java: http://gerrit.cloudera.org:8080/#/c/20477/1/fe/src/main/java/org/apache/impala/analysis/ModifyStmt.java@63 PS1, Line 63: * line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/20477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If15f64944f2e23064b7112ad5930abc775dd65ec Gerrit-Change-Number: 20477 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Sep 2023 15:23:17 +0000 Gerrit-HasComments: Yes
