Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 )
Change subject: IMPALA-12313: (part 1) Refactor modify statements ...................................................................... Patch Set 1: (3 comments) I read through and this looks like an improvement http://gerrit.cloudera.org:8080/#/c/20477/1/fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java File fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java: http://gerrit.cloudera.org:8080/#/c/20477/1/fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java@71 PS1, Line 71: correspond Nit: corresponding http://gerrit.cloudera.org:8080/#/c/20477/1/fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java@104 PS1, Line 104: creates Nit: "created by" http://gerrit.cloudera.org:8080/#/c/20477/1/fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java@131 PS1, Line 131: out parameter referencedColumns I'm guessing this is now the field "referencedColumns_" -- To view, visit http://gerrit.cloudera.org:8080/20477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If15f64944f2e23064b7112ad5930abc775dd65ec Gerrit-Change-Number: 20477 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Sep 2023 18:53:23 +0000 Gerrit-HasComments: Yes
