Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20477 )
Change subject: IMPALA-12313: (part 1) Refactor modify statements ...................................................................... Patch Set 3: (2 comments) Thank you for catching this! I think it was a mistake from my side to change the field's name as well. I changed it when I changed the name of the method (getSourceStmt() -> getQueryStmt()). But for the field member 'sourceStmt_' is more descriptive. http://gerrit.cloudera.org:8080/#/c/20477/2/fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java File fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java: http://gerrit.cloudera.org:8080/#/c/20477/2/fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java@60 PS2, Line 60: Result of the analysis of the internal SelectStmt that produces the rows that : // will be modified. > In the earlier patch set, 'queryStmt_' used to be 'sourceStmt_'. A lot of c Done http://gerrit.cloudera.org:8080/#/c/20477/2/fe/src/main/java/org/apache/impala/analysis/ModifyImpl.java@99 PS2, Line 99: sourceStmt_ > nit: queryStmt_ Done -- To view, visit http://gerrit.cloudera.org:8080/20477 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If15f64944f2e23064b7112ad5930abc775dd65ec Gerrit-Change-Number: 20477 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Sep 2023 10:09:50 +0000 Gerrit-HasComments: Yes
