Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/20428 )
Change subject: IMPALA-9118: Show catalog operation details in catalogd webUI ...................................................................... Patch Set 4: (2 comments) Hi Quanlong, this change looks great, left a nit and a comment. http://gerrit.cloudera.org:8080/#/c/20428/4/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20428/4/be/src/catalog/catalog-server.cc@152 PS4, Line 152: operations nit: operation log records http://gerrit.cloudera.org:8080/#/c/20428/4/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java: http://gerrit.cloudera.org:8080/#/c/20428/4/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@119 PS4, Line 119: if (ddlRequest.isSetHeader()) Users might find it confusing if the DDL Summary would show a different number of in-progress DDL requests that are displayed on the in-progress list. But I am not sure if this actually can be empty. -- To view, visit http://gerrit.cloudera.org:8080/20428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cf3f0da2be2be79e546762a8083d4de338ff6aa Gerrit-Change-Number: 20428 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Wed, 27 Sep 2023 13:54:11 +0000 Gerrit-HasComments: Yes
