Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20428 )
Change subject: IMPALA-9118: Show catalog operation details in catalogd webUI ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/20428/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20428/5/be/src/catalog/catalog-server.cc@953 PS5, Line 953: catalog_op.finish_time_ms > 0 ? : catalog_op.finish_time_ms : UnixMillis() end_time_ms will be set in line 956 and 961. It's duplicated here. http://gerrit.cloudera.org:8080/#/c/20428/5/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/20428/5/common/thrift/JniCatalog.thrift@879 PS5, Line 879: required string details Is 'details' a required field? http://gerrit.cloudera.org:8080/#/c/20428/5/common/thrift/JniCatalog.thrift@886 PS5, Line 886: optional list<TCatalogOpRecord> in_flight_catalog_operations; nit: add comments for what's the order of lists of in-flight operations and finished operations. http://gerrit.cloudera.org:8080/#/c/20428/5/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java: http://gerrit.cloudera.org:8080/#/c/20428/5/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@110 PS5, Line 110: catalogOperationLogSize If catalogOperationLogSize is negative, log size is unlimited http://gerrit.cloudera.org:8080/#/c/20428/5/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/20428/5/tests/custom_cluster/test_web_pages.py@261 PS5, Line 261: --catalog_operation_log_size=2 Could you add test case with catalog_operation_log_size as -1? -- To view, visit http://gerrit.cloudera.org:8080/20428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cf3f0da2be2be79e546762a8083d4de338ff6aa Gerrit-Change-Number: 20428 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Oct 2023 19:07:18 +0000 Gerrit-HasComments: Yes
