k.venureddy2...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20487 )
Change subject: IMPALA-12399: (addendum) Fixed possible deadloop and also do not set the event skip list in notification request to update latestEventId_ ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20487/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20487/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@906 PS4, Line 906: long currentEventId = getCurrentEventId(); > IMO, I don't like the idea of doing an additional RPC call to get the curre This isn't a change with this gerrit. Earlier, it was happening inside getNextMetastoreEvents method before MetastoreShim.getNextNotification call. It is just moved to the caller now. -- To view, visit http://gerrit.cloudera.org:8080/20487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb4b8c3db23d39226f10b33cca4e6a1ab271b925 Gerrit-Change-Number: 20487 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Oct 2023 05:40:42 +0000 Gerrit-HasComments: Yes
