Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20487 )
Change subject: IMPALA-12399: (addendum) Fixed possible deadloop and also do not set the event skip list in notification request to update latestEventId_ ...................................................................... Patch Set 4: Code-Review+1 (1 comment) LGTM. I can bump to +2 if no more comments from other reviewers. http://gerrit.cloudera.org:8080/#/c/20487/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20487/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1068 PS4, Line 1068: lastSyncedEventId_.set(currentEventId); nit: Ideally we should also update 'lastSyncedEventTimeMs_'. But it doesn't worth introducing more complexity for such a rare case. I think it's ok since in production env, HMS events are generated pretty fast and 'lastSyncedEventTimeMs_' will be updated accordingly. -- To view, visit http://gerrit.cloudera.org:8080/20487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb4b8c3db23d39226f10b33cca4e6a1ab271b925 Gerrit-Change-Number: 20487 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 00:52:05 +0000 Gerrit-HasComments: Yes
