Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17842 )
Change subject: IMPALA-5741: Initial support for reading tiny RDBMS tables ...................................................................... Patch Set 24: (4 comments) http://gerrit.cloudera.org:8080/#/c/17842/24//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17842/24//COMMIT_MSG@35 PS24, Line 35: copy-data-sources.sh nit: copy-ext-data-sources.sh http://gerrit.cloudera.org:8080/#/c/17842/24//COMMIT_MSG@42 PS24, Line 42: create-data-source-table.sql nit: create-ext-data-source-table.sql http://gerrit.cloudera.org:8080/#/c/17842/22/testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test File testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test: http://gerrit.cloudera.org:8080/#/c/17842/22/testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test@28 PS22, Line 28: 11,false,1,1,1,10,1.100000023841858,10.1,'01/02/09','1',2009-01-02 00:11:00.450000000 : 12,true,2,2,2,20,2.200000047683716,20.2,'01/02/09','2',2009-01-02 00:12:00.460000000 : 13,false,3,3,3,30,3.299999952316284,30.3,'01/02/09','3',2009-01-02 00:13:00.480000000 : 14,true,4,4,4,40,4.400000095367432,40.4,'01/02/09','4',2009-01-02 00:14:00.510000000 : 20,true,0,0,0,0,0,0,'01/03/09','0',2009-01-03 00:20:00.900000000 > This is time zone issue. jdbc driver use system time zone by default, but I Done http://gerrit.cloudera.org:8080/#/c/17842/24/tests/query_test/test_queries.py File tests/query_test/test_queries.py: http://gerrit.cloudera.org:8080/#/c/17842/24/tests/query_test/test_queries.py@243 PS24, Line 243: @SkipIfCatalogV2.data_sources_unsupported() : def test_jdbc_data_source(self, vector): nit: Can we add metadata test verifying the values of table properties __IMPALA_DATA_SOURCE_*? See _get_properties() and _get_tbl_properties() in tests/metadata/test_ddl_base.py -- To view, visit http://gerrit.cloudera.org:8080/17842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8244e978c7717c6f1452f66f1630b6441392e7d2 Gerrit-Change-Number: 17842 Gerrit-PatchSet: 24 Gerrit-Owner: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Oct 2023 17:51:25 +0000 Gerrit-HasComments: Yes
