Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17842 )
Change subject: IMPALA-5741: Initial support for reading tiny RDBMS tables ...................................................................... Patch Set 25: (6 comments) http://gerrit.cloudera.org:8080/#/c/17842/24//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17842/24//COMMIT_MSG@35 PS24, Line 35: copy-ext-data-source > nit: copy-ext-data-sources.sh fixed http://gerrit.cloudera.org:8080/#/c/17842/24//COMMIT_MSG@42 PS24, Line 42: create-ext-data-source-table > nit: create-ext-data-source-table.sql fixed http://gerrit.cloudera.org:8080/#/c/17842/25/tests/query_test/test_ext_data_sources.py File tests/query_test/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/17842/25/tests/query_test/test_ext_data_sources.py@61 PS25, Line 61: > line has trailing whitespace fixed http://gerrit.cloudera.org:8080/#/c/17842/25/tests/query_test/test_ext_data_sources.py@61 PS25, Line 61: > flake8: W293 blank line contains whitespace fixed http://gerrit.cloudera.org:8080/#/c/17842/25/tests/query_test/test_ext_data_sources.py@85 PS25, Line 85: > flake8: W391 blank line at end of file fixed http://gerrit.cloudera.org:8080/#/c/17842/24/tests/query_test/test_queries.py File tests/query_test/test_queries.py: http://gerrit.cloudera.org:8080/#/c/17842/24/tests/query_test/test_queries.py@243 PS24, Line 243: # These results will vary slightly depending on how the values get split up : # so only run with 1 node and on text. > nit: Can we add metadata test verifying the values of table properties __IM Added test case to verify table properties. Moved data sources related test cases to a new file -- To view, visit http://gerrit.cloudera.org:8080/17842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8244e978c7717c6f1452f66f1630b6441392e7d2 Gerrit-Change-Number: 17842 Gerrit-PatchSet: 25 Gerrit-Owner: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 00:02:33 +0000 Gerrit-HasComments: Yes
