Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20344 )
Change subject: IMPALA-10120: Add required fields for TGetInfoResp when error. ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/20344/5/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/20344/5/be/src/service/impala-hs2-server.cc@1011 PS5, Line 1011: return_val > It seems that the GetLog() interface is only used by the cloudera private d I see. So is it possible that the cloudera jdbc driver hang on this request? We can fix it in a separate JIRA since IMPALA-10120 mostly focus on beeline. http://gerrit.cloudera.org:8080/#/c/20344/5/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/20344/5/tests/common/impala_test_suite.py@1019 PS5, Line 1019: run_stmt_in_impala > It really isn't a good name, but it can align with 'run_stmt_in_hive' whic I think we can leave 'run_stmt_in_hive' using its original name. The TODO also indicates we might change its implementation to use Thrift client instead of beeline in the future. So it's ok to not expose 'beeline' in the method name. We just need to make 'run_stmt_in_impala' more clear since we already have other methods for submitting Impala queries. -- To view, visit http://gerrit.cloudera.org:8080/20344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib42bb82735fb4a8e6911b6a19adb8bd84973300b Gerrit-Change-Number: 20344 Gerrit-PatchSet: 5 Gerrit-Owner: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Comment-Date: Sat, 07 Oct 2023 05:30:48 +0000 Gerrit-HasComments: Yes
