Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20344 )
Change subject: IMPALA-10120: Add required fields for TGetInfoResp when error. ...................................................................... Patch Set 7: Code-Review+1 (2 comments) LGTM. Thanks for digging into this! http://gerrit.cloudera.org:8080/#/c/20344/5/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/20344/5/be/src/service/impala-hs2-server.cc@1011 PS5, Line 1011: > When I dived into GetLog() I found that the 'log' field of 'return_val' par Ah, right. The problem of TGetInfoResp is that 'infoValue' is a required field using a union type (TGetInfoValue), and the union type is not initialized by default. Here the 'log' field of TGetLogResp is using string type which will be initialized by default. http://gerrit.cloudera.org:8080/#/c/20344/7/tests/shell/test_beeline.py File tests/shell/test_beeline.py: http://gerrit.cloudera.org:8080/#/c/20344/7/tests/shell/test_beeline.py@37 PS7, Line 37: > flake8: E241 multiple spaces after ',' Please address this -- To view, visit http://gerrit.cloudera.org:8080/20344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib42bb82735fb4a8e6911b6a19adb8bd84973300b Gerrit-Change-Number: 20344 Gerrit-PatchSet: 7 Gerrit-Owner: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Comment-Date: Sun, 08 Oct 2023 07:14:47 +0000 Gerrit-HasComments: Yes
