Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20557 )
Change subject: IMPALA-12490: Fix tests on ARM ...................................................................... Patch Set 4: Code-Review+2 (1 comment) This looks good to me http://gerrit.cloudera.org:8080/#/c/20557/4/be/src/codegen/llvm-codegen-cache-test.cc File be/src/codegen/llvm-codegen-cache-test.cc: http://gerrit.cloudera.org:8080/#/c/20557/4/be/src/codegen/llvm-codegen-cache-test.cc@272 PS4, Line 272: // 128B for optimal mode Nit: Maybe update this comment -- To view, visit http://gerrit.cloudera.org:8080/20557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id60bd16402c09b9c939edc93a745c07f235b8912 Gerrit-Change-Number: 20557 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Oct 2023 21:24:33 +0000 Gerrit-HasComments: Yes
