Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20557
to look at the new patch set (#5).
Change subject: IMPALA-12490: Fix tests on ARM
......................................................................
IMPALA-12490: Fix tests on ARM
Fixes failing llvm-codegen-cache-test on ARM by increasing the expected
cache entry size to account for different LLVM structure size.
Updates compare_float to use an implementation matching isclose from PEP
485 (added in Python 3.5). The prior implementation only did absolute
comparison, which works increasingly poorly for values greater than 1.
Several cases in test_aggregation.py failed on ARM being off-by-one in
the least significant digit but greater than the 1e-9 absolute epsilon.
The prior link is also considered outdated, now redirecting to
https://randomascii.wordpress.com/2012/02/25/comparing-floating-point-numbers-2012-edition/
which argues for similar treatment to PEP 485.
Retains the same absolute tolerance for double and float to avoid
changing behavior for very small numbers.
Change-Id: Id60bd16402c09b9c939edc93a745c07f235b8912
---
M be/src/codegen/llvm-codegen-cache-test.cc
M tests/common/test_result_verifier.py
2 files changed, 14 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/20557/5
--
To view, visit http://gerrit.cloudera.org:8080/20557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id60bd16402c09b9c939edc93a745c07f235b8912
Gerrit-Change-Number: 20557
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
