Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20355 )
Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline ...................................................................... Patch Set 24: (5 comments) Compared to patch set 13 and it looks OK to me. I just have 1 nit. http://gerrit.cloudera.org:8080/#/c/20355/13/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/20355/13/bin/run-all-tests.sh@64 PS13, Line 64: # Run JS tests : : ${JS_TEST:=false > Done Done http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/chart_commons.js File www/scripts/query_timeline/chart_commons.js: http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/chart_commons.js@80 PS24, Line 80: = 2 nit: nit: define a constant for this assignment. http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/host_utilization_diagram.js File www/scripts/query_timeline/host_utilization_diagram.js: http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/host_utilization_diagram.js@252 PS24, Line 252: <= 2 nit: define a constant for this. http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/host_utilization_diagram.js@266 PS24, Line 266: = 2 nit: I see several loops start from index 2 like this one. Is there any significance on this (ie., good samples are expected to have at least 3 data points)? If yes, can you define a constant somewhere and use that constant for this kind of assignment? http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/host_utilization_diagram.js@271 PS24, Line 271: = 2 nit: define a constant for this assignment. -- To view, visit http://gerrit.cloudera.org:8080/20355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd25e6f0bc9fbd664ec98936daff3f27182dfc7f Gerrit-Change-Number: 20355 Gerrit-PatchSet: 24 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Nov 2023 21:17:47 +0000 Gerrit-HasComments: Yes
