Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/20355 )
Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline ...................................................................... Patch Set 25: (4 comments) http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/chart_commons.js File www/scripts/query_timeline/chart_commons.js: http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/chart_commons.js@80 PS24, Line 80: > nit: nit: define a constant for this assignment. Done http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/host_utilization_diagram.js File www/scripts/query_timeline/host_utilization_diagram.js: http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/host_utilization_diagram.js@252 PS24, Line 252: > nit: define a constant for this. Done http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/host_utilization_diagram.js@266 PS24, Line 266: e a > nit: I see several loops start from index 2 like this one. Is there any sig Done. I have also added a comment to define this constant. http://gerrit.cloudera.org:8080/#/c/20355/24/www/scripts/query_timeline/host_utilization_diagram.js@271 PS24, Line 271: > nit: define a constant for this assignment. Done -- To view, visit http://gerrit.cloudera.org:8080/20355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd25e6f0bc9fbd664ec98936daff3f27182dfc7f Gerrit-Change-Number: 20355 Gerrit-PatchSet: 25 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 08 Nov 2023 07:51:50 +0000 Gerrit-HasComments: Yes
