Saurabh Katiyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20682 )
Change subject: IMPALA-9086: Show Hive configurations in /hadoop-varz page ...................................................................... Patch Set 4: (17 comments) Updated comments and removed trailing white spaces http://gerrit.cloudera.org:8080/#/c/20682/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20682/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-9086: Show Hive configurations in /hadoop-varz page > Add a blank line after the title Done http://gerrit.cloudera.org:8080/#/c/20682/1//COMMIT_MSG@13 PS1, Line 13: > nit: fix the indention Done http://gerrit.cloudera.org:8080/#/c/20682/1//COMMIT_MSG@15 PS1, Line 15: > nit: two "about" Done http://gerrit.cloudera.org:8080/#/c/20682/3/be/src/catalog/catalog-server.h File be/src/catalog/catalog-server.h: http://gerrit.cloudera.org:8080/#/c/20682/3/be/src/catalog/catalog-server.h@329 PS3, Line 329: > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/20682/1/be/src/catalog/catalog-server.h File be/src/catalog/catalog-server.h: http://gerrit.cloudera.org:8080/#/c/20682/1/be/src/catalog/catalog-server.h@329 PS1, Line 329: > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/20682/1/be/src/catalog/catalog.h File be/src/catalog/catalog.h: http://gerrit.cloudera.org:8080/#/c/20682/1/be/src/catalog/catalog.h@143 PS1, Line 143: > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniCatalog.java@124 PS1, Line 124: } > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniCatalog.java@125 PS1, Line 125: > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniCatalog.java@126 PS1, Line 126: private static final HiveConf HIVE_CONF = new HiveConf(); > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniCatalog.java@126 PS1, Line 126: vate static f > We don't need to mention the JIRA id for each changes, unless there are lot Done http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java@629 PS1, Line 629: = new Configuration() > nit: move this commend on HIVE_CONF and mention org.apache.hadoop.hive.conf Done http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java@636 PS1, Line 636: > please help to remove this stale comment. Done http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java@637 PS1, Line 637: * Returns a string of all loaded Hadoop configuration parameters > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java@638 PS1, Line 638: * including Hive configurations > We don't need comments on the current change. We can mention this method Done http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java@639 PS1, Line 639: */ > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/20682/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java@640 PS1, Line 640: public byte[] getAllHadoopConfigs() throws ImpalaException { > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/20682/1/tests/custom_cluster/test_web_pages.py File tests/custom_cluster/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/20682/1/tests/custom_cluster/test_web_pages.py@194 PS1, Line 194: expected_coordinator_links = [ > nit: don't need this comment. Done -- To view, visit http://gerrit.cloudera.org:8080/20682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5af0eb68e71afeed64660d4d40584208ea503217 Gerrit-Change-Number: 20682 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Katiyal <saurabhkati...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Saurabh Katiyal <saurabhkati...@gmail.com> Gerrit-Comment-Date: Thu, 09 Nov 2023 19:03:40 +0000 Gerrit-HasComments: Yes
