Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20682 )
Change subject: IMPALA-9086: Show Hive configurations in /hadoop-varz page ...................................................................... Patch Set 4: (3 comments) Let's add a test in tests/webserver/test_web_pages.py to verify some key configurations appear on the WebUI of catalogd and impalads, e.g. hive.metastore.warehouse.dir, hive.metastore.warehouse.external.dir, and fs.defaultFs, etc. http://gerrit.cloudera.org:8080/#/c/20682/4/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/20682/4/fe/src/main/java/org/apache/impala/service/JniCatalog.java@547 PS4, Line 547: a string of nit: remove "a string of". This comes from the stale comment. We now return the serialized byte array of TGetAllHadoopConfigsResponse instead of a string. http://gerrit.cloudera.org:8080/#/c/20682/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/20682/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java@632 PS4, Line 632: getHadoopConfigAsHtml nit: This is the old method name. Let's use 'getAllHadoopConfigs'. http://gerrit.cloudera.org:8080/#/c/20682/4/fe/src/main/java/org/apache/impala/service/JniFrontend.java@633 PS4, Line 633: //org.apache.hadoop.hive.conf.HiveConf inherrits org.apache.hadoop.conf.Configuration nit: Add a space after "//" -- To view, visit http://gerrit.cloudera.org:8080/20682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5af0eb68e71afeed64660d4d40584208ea503217 Gerrit-Change-Number: 20682 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Katiyal <saurabhkati...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Saurabh Katiyal <saurabhkati...@gmail.com> Gerrit-Comment-Date: Fri, 10 Nov 2023 01:21:24 +0000 Gerrit-HasComments: Yes
