Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20692 )
Change subject: IMPALA-11542: Implement pre-allocation in LLVM memory manager ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/20692/11/be/src/thirdparty/llvm/SectionMemoryManager.cpp File be/src/thirdparty/llvm/SectionMemoryManager.cpp: http://gerrit.cloudera.org:8080/#/c/20692/11/be/src/thirdparty/llvm/SectionMemoryManager.cpp@47 PS11, Line 47: return std::max(Alignment, StubAlign); > Agree, this version is already a great improvement for ARM support and does Updated with feedback from the LLVM review. It still works on ARM - https://jenkins.impala.io/job/ubuntu-20.04-from-scratch-ARM/58/ - and I also have successful ASAN and UBSAN runs. Considering this ready unless someone jumps in with more feedback. -- To view, visit http://gerrit.cloudera.org:8080/20692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675 Gerrit-Change-Number: 20692 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 22 Nov 2023 23:55:23 +0000 Gerrit-HasComments: Yes
